Made gcp configuration optional#32
Merged
Merged
Conversation
… own github secret and action variables to use for oidc auth
TylerMizuyabu
changed the title
TylerMizuyabu
force-pushed
the
made-gcs-configuration-optional
branch
from
782bb21 to
2930b81
Compare
bzarboni1
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the gcs configuration to be optional. If not set no action or secrets will be made in the github foundations organization. This is for the use case where a user brings their own cloud provider, with this they can now disable the gcp variable and secret setup, define their own secrets and variables required to auth against their cloud in their github workflows, then modify the workflows and use github foundations with their cloud.